Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
!
is used
if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.source scripts/check_commits.sh
, and the commit history is certified to follow clean commit guidelines as described
here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/COMMIT_GUIDELINES.mdmain
have been incorporated to this PR by simple rebase if possible, if not, then conflicts are resolved appropriately.Currently, the repo has 2292 uncovered lines of code. We should have 100% test coverage. This PR adds comprehensive test coverage for 5 core modules that previously had 0% test coverage.
/claim #560 fixes #560
These modules are fundamental components of the proof-of-sql system:
ParseError
is used throughout the codebase for error handlingLiteralValue
handles all data types in SQL queriesTableRef
is crucial for table reference parsingEmptyExec
is a core proof plan componentlog_memory_usage
is used extensively in proof evaluationParseError
enum covering error creation, display, equality, cloning, and trait implementationsLiteralValue
enum covering all variants (Boolean, integers, strings, binary, decimal, scalar, timestamp) and their conversionsTableRef
struct covering all constructors, parsing methods, traits, and edge casesEmptyExec
covering all ProofPlan trait methods and evaluation functionslog_memory_usage
utility function ensuring it handles various inputs gracefullyTotal: 63 new tests covering ~740 lines of test code.
Yes. All 63 tests pass successfully:
https://github.com/user-attachments/assets/76845aeb-1d42-4688-a112-23433cf222c5
RUSTFLAGS="-Clink-arg=-fuse-ld=gold" BLITZAR_BACKEND=cpu cargo test --lib -- error::tests literal_value::tests table_ref::tests empty_exec::tests log::tests
# Result: 63 passed; 0 failed
The tests themselves are the changes in this PR. They provide comprehensive coverage including:
Rishi Mondal
@MAVRICK-1
Space and Time
@spaceandtimelabs