Started adding tests. Will try to cover code that would add value.
/claim #560
!
is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh
.source scripts/check_commits.sh
, and the commit history is certified to follow clean commit guidelines as described here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/COMMIT_GUIDELINES.mdmain
have been incorporated to this PR by simple rebase if possible, if not, then conflicts are resolved appropriately.Gradually increasing test coverage
proof-of-sql-parser/src/posql_time/timezone.rs
proof-of-sql-parser/src/posql_time/timestamp.rs
proof-of-sql-parser/src/identifier.rs
proof-of-sql-parser/src/intermediate_ast.rs
Additionally, added check for time zone boundaries, hours should not be over 12, and minutes should not be over 60 (please correct me if I am doing it wrong). This change is also tested
Ignored because some tests felt redundant, I am open for suggestions.
proof-of-sql/src/base/arrow/owned_and_arrow_conversions.rs
proof-of-sql/src/base/arrow/column_arrow_conversions.rs
proof-of-sql/src/base/database/column_repetition_operation.rs
Yes.
Tarin Mahmood
@tmahmood
Space and Time
@spaceandtimelabs